Comment by TheDong

Comment by TheDong 2 hours ago

3 replies

> Notably [go] ended up giving up on [gerrit]

That's not accurate. They more or less only use Gerrit still. They started accepting Github PRs, but not really, see https://go.dev/doc/contribute#sending_a_change_github

> You will need a Gerrit account to respond to your reviewers, including to mark feedback as 'Done' if implemented as suggested

The comments are still gerrit, you really shouldn't use Github.

The Go reviewers are also more likely than usual to assume you're incompetent if your PR comes from Github, and the review will accordingly be slower and more likely to be rejected, and none of the go core contributors use the weird github PR flow.

miroljub 2 minutes ago

Many people confuse competence and dedication.

A competent developer would be more likely to send a PR using the tool with zero friction than to dedicate a few additional hours of his life to create an account and figure out how to use some obscure.

ncruces 33 minutes ago

> The Go reviewers are also more likely than usual to assume you're incompetent if your PR comes from Github

I've always done it that way, and never got that feeling.

  • arccy a minute ago

    there's certainly a higher rejection rate for github PRs