Comment by MutableLambda

Comment by MutableLambda 2 days ago

23 replies

Have you seen JPEG XL source code? I like the format, but the reference implementation in C++ looked pretty bad at least 2 years ago. I hope they rewrote it, because it surely looked like a security issue waiting to happen.

jsheard 2 days ago

That's why both Mozilla and Google have predicated their JXL support on a memory-safe implementation. There's a Rust one in the works.

I think Google are aiming to replace all of Chromiums decoders with memory-safe ones anyway, even for relatively simple formats.

chimeracoder 2 days ago

> Have you seen JPEG XL source code? I like the format, but the reference implementation in C++ looked pretty bad at least 2 years ago. I hope they rewrote it, because it surely looked like a security issue waiting to happen.

At this point, in 2025, any substantial (non-degenerative) image processing written in C++ is a security issue waiting to happen. That's not specific to JPEG XL.

  • spookie 2 days ago

    Well, the first public implementation dates to 2020. And, the Cpp choice is obvious, simpler integration with the majority of existing image processing libs, tools and utilities. Not to mention GUI toolkits.

    Nonetheless, we should really bear in mind how entrenched Cpp is. If you normalize CVEs by language popularity Java looks downright dangerous!

  • SoKamil 2 days ago

    > any substantial (non-degenerative)

    Why this quality poses security issues?

  • izacus 2 days ago

    And yet whole of HN is VERY VERY angry because Google won't ship that pile of C++ into most popular software (and app framework) in the world.

    • usrnm 2 days ago

      The most popular software in question is also a giant pile of C++, btw.

      • ncruces a day ago

        Are you familiar with the rule of two?

        https://chromium.googlesource.com/chromium/src/+/main/docs/s...

        No new code goes in that violates the rule, and ideally no code at all goes in that is both unsafe and parses untrusted data (regardless of sandboxing) and old code doing both gets replaced.

        A giant pile of C++ can be used for rendering, not parsing untrusted data. A giant pile of C++ can sit behind a validator: a memory-safe JSON validator can vet a stream, before an C++ library deserializes it. Etc.

      • izacus 2 days ago

        What are you saying here?

    • mort96 2 days ago

      Mozilla's position for some time now has been, "we aren't opposed to shipping JXL support, but we'd want to ship a decent implementation in a memory safe language, not the reference C++ implementation". That position hasn't been met with very much criticism.

      Google's position, on the other hand, has been a flat-out "no, we will not ship JXL". That's what has been met with criticism. Not an imagined reluctance to shipping a C++ JXL implementation.

    • ux266478 2 days ago

      Who is saying Google should ship the reference implementation? It's a standard, and Google has the labor to write their own implementation.

      • jeffbee 2 days ago

        Google did write one. They wrote the bad one that we're discussing.

      • izacus 2 days ago

        That sounds like an even more request for someone to do for free, doesn't it?