Comment by nradov

Comment by nradov 2 days ago

5 replies

Five years ago we had pretty good static analysis tools for popular languages which could automate certain aspects of code reviews and catch many common defects. Those tools didn't even use AI, just deterministic pattern matching. And yet due to laziness and incompetence many developers didn't even bother taking full advantage of those tools to maximize their own productivity.

ben_w 2 days ago

The devs themselves can still be lazy, claude and copilot code review can be automated on all pull requests by demand of the PM — and the PM can be lazy and ask the LLMs to integrate themselves.

And the LLMs can use the static analysis tools.

  • lmm 11 hours ago

    An LLM can run the static analysis tool and copy/paste its output onto your PR, sure. I'm not sure I would call that "doing code review".

    • ben_w 3 hours ago

      > copy/paste

      I did not say that.

      That it can *also* use tools to help, doesn't mean it can *only* get there by using tools.

      They can *also* just do a code review themselves.

      As in, I cloned a repo of some of my old manually-written code, cd'd into it, ran `claude`, and gave it the prompt "code review" (or something close to that), and it told me a whole bunch of things wrong with it, in natural language, even though I didn't have the relevant static analysis tools for those languages installed.

  • lisbbb a day ago

    I can't even imagine what time wasting bs the LLMs are finding with static analysis tools! It's all just a circle jerk everywhere now.

lisbbb a day ago

Static analysis was pretty limited imho. It wasn't finding anything that interesting. I spent untold hours trying to satisfy SonarQube in 2021 & 2022. It was total shit busy work they stuck me with because all our APIs had to have at least 80% code coverage and meet a moving target of code analysis profiles that were updated quarterly. I had to do a ton of refactoring on a lot of projects just to make them testable. I barely found any bugs and after working on over 100 of those stupid things, I was basically done with that company and its bs. What an utter waste of time for a senior dev. They had to have been trying to get me to quit.