Comment by skydhash

Comment by skydhash 21 hours ago

5 replies

I see the usefulness. But my client is magit, and committing and rebasing are so quick that this will reduce perhaps 30 seconds to one minute to my workflow. And I do not like most rust tools, because they're too dependency heavy.

kccqzy 19 hours ago

Definitely. The instant fixup feature is just three keystrokes away (s c F). The only thing this helps is when you don't want to spend the extra brain cycles to figure out which commit to fixup on.

1718627440 18 hours ago

The task that absorb speeds up is finding the commit where each hunk was last changed. The actual committing and rebaseing is still basically the same.

  • skydhash 18 hours ago

    Git blame using `M-x vc-annotate` with Emacs. But If I have a clean PR that usually means one to three commits (If it's not a big refactoring). So the whole point become moot. In magit, if you create a fixup or a squash commit, it will present you with the log to select the target.

    • gpderetta 6 hours ago

      Yes, or magit-blame, but if you still have multiple commits in your history that you are working on, and you need to break up the current changes in a bunch of instant fixups, figuring out which one is the right one can be a bit time consuming. I'm not convinced that automatically amending to the last commit that touched that line is safe, but I'm willing to try git-absorb.

      • 1718627440 5 hours ago

        > I'm not convinced that automatically amending to the last commit that touched that line is safe, but I'm willing to try git-absorb.

        It is not, but git absorb only produces fixup commits, you can still change what they change in the autosquash step.