Comment by wiether

Comment by wiether 4 days ago

2 replies

I like the idea!

File `apps/client/electron/main/proxy-routing.ts` line 63

Adding a comment to explain why the downgrade is done would have resulted in not raising the issue?

Also two suggestions on the UI

- anchors on lines

- anchors on files and ability to copy a filename easily

lawrencechen 4 days ago

Good suggestions! Will make it more URL friendly.

> Adding a comment to explain why the downgrade is done would have resulted in not raising the issue?

Trying it out here with a new PR on same branch: https://0github.com/manaflow-ai/cmux/pull/809

Will check back on it later!

EDIT: seems like my comment online 62 got highlighted. Maybe we should surface the ability edit the prompt.

  • wiether 3 days ago

    Thanks for the test!

    Thinking about it with the feedback, I'm not sure of what I would have liked to see actually.

    First I was expecting no highlight once you added a comment explaining why.

    But then, seeing the highlight, I'm thinking that a comment shouldn't a magical tool to allow doing crazy stuff.

    I don't know anything about the Electron wrapper, so maybe it is actually possible to do HTTPS and someone could point out how to achieve this. And having the downgrade highlighted can help having this someone finding out.

    I'll keep thinking about it! Thanks!