Comment by TuxSH

Comment by TuxSH 5 hours ago

0 replies

> that's gonna be squashed

Isn't your interpretation backwards in some cases? What I mean, is that _because_ you see the intermediate commits are garbage, you _then_ decide not to review the individual commits (because you are interested in the contribution anyway).

I certainly do care for the hobby FOSS projects I maintain, and bad commit messages + mega-commits won't fly at my day job.

Squash-merging has the advantages of making 1 PR == one commit with the PR ID in the commit message, sure, but it's unfortunately promotes bad Git hygiene (and works around it)