Comment by DTrejo

Comment by DTrejo 2 days ago

Very glad you're working on this! Here is my wish list as a code reviewer:

1. Allow me to step through the code execution paths that have been modified in the pull request, based on the tests that have been modified.

2. Allow me to see the data being handled in variables as I look through the code.

3. Allow me to see code coverage of each part of the code.

4. Show me the full file as I am navigating through the program execution so that I can feel the level of abstraction and notice nearby repetition or code that would benefit from being cleaned up.

Full article: https://dtrejo.com/code-reviews-sad

akshaysg 2 days ago

> 1. Allow me to step through the code execution paths that have been modified in the pull request, based on the tests that have been modified.

Not sure if I fully grasp this! We tried to kind of do this in previous iterations (show call graphs all at once) and it gets messy very fast. Could you elaborate on this point in particular?

Reply View 1 reply

DTrejo 14 hours ago

Sure - imagine my PR adds one new test which test one new function.
Starting from the test, allow me to step through the program execution, just like a debugger, to observe variables, surrounding code, and the complete file.
If you read only the covered lines of code in a linear way, you'd miss the refactoring opportunities because you aren't looking at the rest of the file.

Reply View | 0 replies