Comment by vhantz

Comment by vhantz 11 hours ago

Link to the patch and details on the issue the compiler missed that was found by the model or it didn't happened.

lukeh 11 hours ago

Sure. It was an uninitialized variable in the retry loop below. Fixed now.

amelius 6 hours ago

Look like valgrind would be able to catch that too.

Reply View | 0 replies
vhantz 9 hours ago

There's no such thing being fixed in those diffs

Reply View | 3 replies
- quietbritishjim 9 hours ago
  
  I think it contains the bug (min_attempts), not the fix.
  
  Reply View | 2 replies
  
  lukeh 8 hours ago
  
  This is the fix. The bug commit was squashed. I don’t really know what I need to prove here, except that Claude Code helped identify an issue and fix it.
  
  Reply View | 1 reply
  
  vhantz 5 hours ago
  
  Compilers have been warning about unitialized variables for a very long time now. The claim was that the compiler missed that in a patch you reviewed for the kernel. The link posted does not show the review discussion nor a commit log showing that incremental fix, and so does not at all support the claim.
  
  Reply View | 0 replies

usr1106 6 hours ago

What about: Could you please give us links to patches before and after or any other details

(has already happened, just commenting on the comment style)