objclxt 15 hours ago

> How the hell did this pass code review? Are booleans strings on Android?

You are misreading the documentation, it's a key/value API.

`DISALLOW_FUN` is the string key you pass to `setUserRestriction`, which takes a boolean value.

Reply View 2 replies
  • uncircle 15 hours ago

    That makes more sense. Thanks.

    Reply View 1 reply
    • izacus 15 hours ago

      Also this is an enterprise policy constant, so it gets sent (and configured) as string/string dictionary via REST API from MDM backend. That's mostly because the constants can be of mixed types (e.g. "MAX_PASSWORD_CHARS" : "1", "DISALLOW_NETWORK_SWITCHING: "true" - example, constants not actual).

      Reply View 0 replies
stevepotter 13 hours ago

Someone else pointed out the reason for the datatype. A more subtle problem is the use of double negatives. Boolean APIs like "disable" will throw off users of your API.

Reply View 0 replies