Comment by worik
> If the function is called from 37 places, you need to refactor your code,
Really?
I do not have to think hard before I have a counter exampl: authentication
I call authenticate() is some form from every API
All 37 of them
> If the function is called from 37 places, you need to refactor your code,
Really?
I do not have to think hard before I have a counter exampl: authentication
I call authenticate() is some form from every API
All 37 of them
> Because then you are calling middleware_caching_auth_broker() from 37 places
No you aren't. You aren't really calling it from anywhere. The framework you're using, which you aren't writing, is calling the registered middleware.
The topic here is complexity for the code structure because it's called from 37 different places. A registered middleware doesn't run into that issue because it doesn't get called anywhere that "code structure complexity" matters.
Your reasoning is isomorphic to "I'm calling a bit shift millions of times because I have written some code in a programming language." Technically true but not what we're talking about here.
If you are explicitly calling authenticate() for each api, you’re doing it “wrong”. At that point you want implied authentication not explicit authentication. Why not move it to some middleware that gets called in every api call?