Comment by hackpelican
Comment by hackpelican a day ago
In some companies, (ahem… Amazon), engineers are judged by their code review/comment ratio. Especially L4 engineers trying to make it to L5.
So actually putting positive comments in the code review isn’t really much appreciated.
I gained this habit and now for me, a comment is a suggestion of improvement, I deliver praise out-of-band.
> engineers are judged by their code review/comment ratio
It's a horrible practice with adverse incentives, and one of the reasons I'm glad I no longer work there
(and easily gameable, anyways - people would just DM each other patches they were unsure of, before submitting an actual CR)