Comment by mtklein

Comment by mtklein 3 months ago

26 replies

I have always thought that punning through a union was legal in C but UB in C++, and that punning through incompatible pointer casting was UB in both.

I am basing this entirely on memory and the wikipedia article on type punning. I welcome extremely pedantic feedback.

jcranmer 3 months ago

> punning through a union was legal in C

In C89, it was implementation-defined. In C99, it was made expressly legal, but it was erroneously included in the list of undefined behavior annex. From C11 on, the annex was fixed.

> but UB in C++

C++11 adopted "unrestricted unions", which added a concept of active members that is UB to access other members unless you make them active. Except active members rely on constructors and destructors, which primitive types don't have, so the standard isn't particularly clear on what happens here. The current consensus is that it's UB.

C++20 added std::bit_cast which is a much safer interface to type punning than unions.

> punning through incompatible pointer casting was UB in both

There is a general rule that accessing an object through an 'incompatible' lvalue is illegal in both languages. In general, changing the const or volatile qualifier on the object is legal, as is reading via a different signed or unsigned variant, and char pointers can read anything.

  • trealira 3 months ago

    > In C99, it was made expressly legal, but it was erroneously included in the list of undefined behavior annex.

    In C99, union type punning was put under Annex J.1, which is unspecified behavior, not undefined behavior. Unspecified behavior is basically implementation-defined behavior, except that the implementor is not required to document the behavior.

    • ryao 3 months ago

      We can use UB to refer to both. :)

      • hermitdev 3 months ago

        > We can use UB to refer to both. :)

        You can, but in the context of the standard, you'd be wrong to do so. Undefined behavior and unspecified behavior have specific, different, meanings in context of the C and C++ standards.

        Conflate them at your own peril.

        • JadeNB 3 months ago

          > > We can use UB to refer to both. :)

          > You can, but in the context of the standard, you'd be wrong to do so. Undefined behavior and unspecified behavior have specific, different, meanings in context of the C and C++ standards.

          > Conflate them at your own peril.

          I think that ryao was not conflating them, but literally just pointing out, as a joke, that "UB" can stand for "undefined behavior" or "unspecified behavior." Taking advantage of this is inviting dangerous ambiguity, which is why ryao's suggestion ended with ":)," but I think that saying that it's wrong is an overstateent.

      • trealira 3 months ago

        Maybe, but we were talking about "undefined behavior," not "UB," so the point is moot.

        • [removed] 3 months ago
          [deleted]
ryao 3 months ago

There has been plenty of misinformation spread on that. One of the GCC developers told me explicitly that type punning through a union was UB in C, but defined by GCC when I asked (after I had a bug report closed due to UB). I could find the bug report if I look for it, but I would rather not do the search.

  • trealira 3 months ago

    From a draft of the C23 standard, this is what it has to say about union type punning:

    > If the member used to read the contents of a union object is not the same as the member last used to store a value in the object the appropriate part of the object representation of the value is reinterpreted as an object representation in the new type as described in 6.2.6 (a process sometimes called type punning). This might be a non-value representation.

    In past standards, it said "trap representation" rather than "non-value representation," but in none of them did it say that union type punning was undefined behavior. If you have a PDF of any standard or draft standard, just doing a search for "type punning" should direct you to this footnote quickly.

    So I'm going to say that if the GCC developer explicitly said that union type punning was undefined behavior in C, then they were wrong, because that's not what the C standard says.

    • amboar 3 months ago

      Section J.1 _Unspecified_ behavior says

      > (11) The values of bytes that correspond to union members other than the one last stored into (6.2.6.1).

      So it's a little more constrained in the ramifications, but the outcomes may still be surprising. It's a bit unfortunate that "UB" aliases to both "Undefined behavior" and "Unspecified behavior" given they have subtly different definitions.

      From section 4 we have:

      > A program that is correct in all other aspects, operating on correct data, containing unspecified behavior shall be a correct program and act in accordance with 5.1.2.4.

    • ryao 3 months ago

      Here is what was said:

      > Type punning via unions is undefined behavior in both c and c++.

      https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118141#c13

      Feel free to start a discussion on the GCC mailing list.

      • trealira 3 months ago

        I actually might, although not now. Thanks for the link. I'm surprised he directly contradicted the C standard, rather than it just being a misunderstanding.

  • uecker 3 months ago

    Union type punning is allowed and supported by GCC: https://godbolt.org/z/vd7h6vf5q

    • ryao 3 months ago

      I said that GCC defines type punning via unions. It is an extension to the C standard that GCC did.

      That said, using “the code compiles in godbolt” as proof that it is not relying on what the standard specifies to be UB is fallacious.

      • uecker 3 months ago

        I am a member of the standards committee and a GCC maintainer. The C standard supports union punning. (You are right though that relying on godbolt examples can be misleading.)

  • jotux 3 months ago
    • ryao 3 months ago

      What is your point? I already said that GCC defines it even though the C standard does not. As per the GCC developers:

      > Type punning via unions is undefined behavior in both c and c++.

      https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118141#c13

      • jotux 3 months ago

        > One of the GCC developers told me explicitly that type punning through a union was UB in C, but defined by GCC when I asked

        I just was citing the source of this for reference.