pavel_lishin 2 days ago

There must be a better way to tell if a repo is a Sapling repo than by running some arbitrary binary, right?

Reply View 2 replies
  • Symbiote 2 days ago

    For Git one could look for .git/config. There must be something equivalent.

    Reply View 1 reply
    • remram 12 hours ago

      .git will be a file and not a directory, if you are in a submodule or a worktree.

      You just illustrated why trying to assume the functionality of a third-party app instead of calling it creates even more bugs.

      Reply View 0 replies
pasc1878 2 days ago

Use the full path of sl and not rely on $PATH in the same way cron and macOS GUI apps do for I assume this exact reason.

Reply View 12 replies
  • stonegray 2 days ago

    Is the full path guaranteed? For example homebrew, snap, and apt might put it all in different places. $PATH is a useful tool.

    Reply View 2 replies
    • pasc1878 2 days ago

      But not in this case where you have two executables with the same name.

      You have to know where the tool was installed or else be certain no other sl is on your path.

      Reply View 0 replies
    • [removed] 2 days ago
      [deleted]
      Reply View 0 replies
  • Joker_vD 2 days ago

    How would knowing the full path help you anyway? It's either in "/usr/bin/sl", or "/usr/local/bin", or "~/.local/bin", now what?

    By the way, believe it or not, POSIX compliance requires existence of only two directories (/dev and /tmp) and three files (/dev/console, /dev/null, and /dev/tty) on the system; everything else is completely optional, including existence of /bin, /etc, and /usr.

    Reply View 4 replies
    • pasc1878 a day ago

      Because you know what you installed and so which sl to use.

      Reply View 3 replies
      • Joker_vD a day ago

        But the sl is not invoked by you. It is invoked by some npm module (a 5-times-removed dependency from any side) which hopes that either there is "sl" in the $PATH and it is the Sapling CLI, or there is no "sl" in the $PATH. This module can't use absolute paths because it does not know how the end user's system looks.

        Reply View 2 replies
  • skipants 2 days ago

    What if the full path is just `/usr/bin/sl`?

    Reply View 1 reply
    • pasc1878 2 days ago

      Then yopu get the sl there which could be correct.

      Reply View 0 replies
  • charcircuit 2 days ago

    Finding the full path of sl requires looking at $PATH

    Reply View 1 reply
    • pasc1878 2 days ago

      In this case not as then you find the wrong sl - you need to know where the correct sl was installed.

      Reply View 0 replies