Comment by thedufer

Comment by thedufer 3 days ago

Our code review process involves a reviewer explicitly taking ownership of the PR, and I think it's a reasonable expectation with the right practices around it. A good reviewer will request a PR containing 1000s of lines be broken up without doing much more than skimming to make sure it isn't bulked up by generated code or test data or something benign like that.

aaomidi 3 days ago

And just to add to this, at least in Google generated code is never seen in a code review. That’s all just handled by Bazel behind the scenes.

Reply View 1 reply

thedufer 2 days ago

Ah, we draw a distinction between checked-in generated code and JIT generated code, and the former does show up in code review (which is sometimes the point of checking it in - you can easily spot check some of it to make sure the generator behaves as you expect).

Reply View | 0 replies