Comment by awkward

Comment by awkward 3 days ago

4 replies

Github's code review tool is uniquely bad. Notably it presents every comment as blocking and requiring sign off - even a "Glad someone cleaned this up! <thumbs up emoji>" needs clearing before merge.

It also has some UX snafus that cause reviewers to write a number of comments and then forget to publish any of them, leading to a lot of interactions along the lines of "I thought you were going to review my PR?" "I already did?"

plorkyeran 3 days ago

Requiring every comment to be resolved is not a standard part of GitHub’s code review system. That is something which your organization has gone out of its way to require.

  • awkward 2 days ago

    This has been consistent across four organizations including one I participated in setting up. They don't seem to have gone far out of their way.

etothet 2 days ago

Overall, I personally find the experience better than Gitlab's merge request UI/UX.