Comment by jofer

Comment by jofer 5 days ago

0 replies

This x1000. It's not about the org, really. It's about what's being changed.

Yes, a lot of large codebases have things that look wrong. They're not always wrong. Trying to clean up what look like cobwebs at the core of a large codebases often means removing things that are there for a reason. The reason is usually counterintuitive and could be documented better. But often only a few people can really evaluate the change.

A small PR is likely to be accepted quickly, and a large PR is likely to take awhile. No one gets upset by that, though.

The flip side is that a small PR to a critical part of the codebase is also likely to take awhile and be treated as "default to no". It's often hard to see that from the "outside", though.

With that said, trying to go the extra mile and make things clear, concise, and better documented than before goes a long way in getting an MR reviewed quickly.