Comment by jicea

Comment by jicea 2 months ago

1 reply

Absolutely! I'm the maintainer of a small Open Source project [1] and this phrase makes me tickle.

I totally get it that a maintainer doesn't want to merge some code, even if it's totally working. Is the new feature a niche case, or has if a wide audience? Is it aligned with the project goal/philosophy? Will it be easy to maintain/evolve/debug? Does it add unnecessary/unwanted dependencies? At the end of the day, the maintainer will be the person that have to work/support with this code.

Please keep in mind that if you've spent an hour on a project, maintainers have have certainly spent hundreds if not thousands more time on it.

[1]: https://github.com/Orange-OpenSource/hurl

account42 2 months ago

Exactly. And this is why you should talk to maintainers before spending significant time on your pet feature if your goal is to get it upstreamed. Don't just dump code on others and then get upset if they don't like it as much as you do.