Comment by bawolff

Comment by bawolff 10 months ago

2 replies

https://duo.com/blog/duo-finds-saml-vulnerabilities-affectin... has the full details.

But basically in some xml apis, a comment can split a single text node into two adjacent text nodes. Some implementations would only look at the first text node. The original xsignature spec (although i think this has been changed) said to remove all comments from doc before signing it, so the attacker can add arbitrary comments without messing up the signature.

mdaniel 10 months ago

> so the attacker can add arbitrary comments without messing up the signature.

Right, I believe you, but the original assertion was "change meaning of document" -- I can likely add arbitrary whitespace, too, under that same "tomato, tomahto" canonicalization path, but how do either of those two insertions benefit the attacker by changing the meaning of the document?

  • bawolff 10 months ago

    Comments affect the dom structure of parsed xml subtley. There were cases where this was enough to log in as a different user. See the link i provided.